|
Size: 1074
Comment:
|
Size: 2700
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 1: | Line 1: |
| <<Include(A:style)>> |
|
| Line 3: | Line 5: |
| This page explain the Mercurial Patch Review Process and how (anyone) can help. | This page explains the Mercurial patch review process and how (anyone) can help. |
| Line 8: | Line 10: |
| * All reviews happen one MailingLists#The_Mercurial-Devel_list | * All reviews happen on MailingLists#The_Mercurial-Devel_list |
| Line 10: | Line 12: |
| * Contributor follow the ContributingChanges and send they patch to the list (hopefully using the PatchbombExtension) | * Contributors follow the ContributingChanges and send their patch(es) to the list (hopefully using the PatchbombExtension) |
| Line 12: | Line 14: |
| * Review are just email reply to the emailed patch | * Reviews are just email replies to the emailed patch |
| Line 18: | Line 20: |
| * The patch is compliant to the ContributingChanges bullet list. | * The patch should conform to the ContributingChanges bullet list. |
| Line 20: | Line 22: |
| Quick reminder of important thing: | Quick reminder of important things: |
| Line 24: | Line 26: |
| * Patch does one and one thing, | * Patch does one and only one thing, |
| Line 38: | Line 40: |
| If any concerns raised, reply to the email asking question. | If any concerns raised, reply to the email asking questions. |
| Line 42: | Line 44: |
== Accepters Review Checklist == Some people are blessed to accept patches and push them to a repo where Matt Mackall ultimatly pull from. Here is another check list for them * Run check code on all patches * Run the whole test suites * Reply to the list saying that you took care of the patch * you can get the patches files directly from http://hgpatches.durin42.com/patches/<node> Appropriate hg alias would be: {{{ [alias] getpatch=import --partial --obsolete http://review.octopoid.net/patches/$1/raw.txt }}} * Make sure you created obsolescence marker between the node in the patch and the one you created, e.g. {{{#!bash hg import --partial --obsolete <patches>: }}} * use the [[https://bitbucket.org/marmoute/mutable-history/src/98b5ac44a25913e546f4588dba5b7a1db39c82d4/hgext/drophack.py?at=default|drophack extension]] if you need to drop a changeset you queued * Rebase your queue on top of main's ```@``` * Move ```@``` with the changeset you pushed. * Update [[http://patchwork.serpentine.com/project/hg/list/|Patchwork]] once you have pushed |
|
| Line 44: | Line 82: |
| * Patchwork | * [[http://patchwork.serpentine.com/project/hg/list/|Patchwork]] ([[http://hgpatches.appspot.com/?days=30|backlog plot]]) |
| Line 46: | Line 84: |
| * Patch bomb | * [[http://hgpatches.durin42.com/|The Patches Bot]] ([[http://hg.durin42.com/patchbot/|sources]]) |
| Line 48: | Line 86: |
| * Collection of script | * [[http://42.netv6.net/reviewtools/|Collection of script]] * Various data collection [[http://review.octopoid.net/]] (STALED) * Matt Mackall Inbox [[http://www.selenic.com/inbox|Metrix (nb email, nb patches, oldest email (in day))]] and [[http://www.selenic.com/inflight|Content]]. |
|
This page does not meet our
Patch Review Process
This page explains the Mercurial patch review process and how (anyone) can help.
1. Generic Fact
All reviews happen on MailingLists#The_Mercurial-Devel_list
Contributors follow the ContributingChanges and send their patch(es) to the list (hopefully using the PatchbombExtension)
- Reviews are just email replies to the emailed patch
Everyone is welcome to do review.
2. Simple Review Checklist
The patch should conform to the ContributingChanges bullet list.
- Quick reminder of important things:
- commit message format,
- Patch does one and only one thing,
- Change is tested
- Documentation augmented an updated
- (all the other things in the list)
- You understand the change
- The change seems correct
- The change seems efficient
If any concerns raised, reply to the email asking questions.
If everything sounds good, reply to the email too. Just state it looks good to you.
3. Accepters Review Checklist
Some people are blessed to accept patches and push them to a repo where Matt Mackall ultimatly pull from.
Here is another check list for them
- Run check code on all patches
- Run the whole test suites
- Reply to the list saying that you took care of the patch
you can get the patches files directly from http://hgpatches.durin42.com/patches/<node> Appropriate hg alias would be:
[alias] getpatch=import --partial --obsolete http://review.octopoid.net/patches/$1/raw.txt
- Make sure you created obsolescence marker between the node in the patch and the one you created, e.g.
hg import --partial --obsolete <patches>:
use the drophack extension if you need to drop a changeset you queued
Rebase your queue on top of main's @
Move @ with the changeset you pushed.
Update Patchwork once you have pushed
4. Review Tooling
Various data collection http://review.octopoid.net/ (STALED)
Matt Mackall Inbox Metrix (nb email, nb patches, oldest email (in day)) and Content.