Differences between revisions 3 and 13 (spanning 10 versions)
⇤ ← Revision 3 as of 2014-04-12 21:21:27 →
Size: 1074
Editor: Pierre-YvesDavid
Comment:
← Revision 13 as of 2014-04-14 05:06:06 → ⇥
Size: 2218
Editor: Sean Farley
Comment: add debugobsolete example
Deletions are marked like this. Additions are marked like this.
Line 42: Line 42:

== Accepters Review Checklist ==

Some people are blessed to accept patches and push them to a repo where Matt Mackall ultimatly pull from.

Here is another check list for them

 * Run check code on all patches

 * Run the whole test suites

 * Reply to the list saying that you took care of the patch

 * Make sure you created obsolescence marker between the node in the patch and the one you created, e.g.

  {{{#!bash
hg debugobsolete $EMAIL_NODE $NEW_NODE
}}}

 * use the [[https://bitbucket.org/marmoute/mutable-history/src/98b5ac44a25913e546f4588dba5b7a1db39c82d4/hgext/drophack.py?at=default|drophack extension]] if you need to drop a changeset you queued

 * Rebase your queue on top of main's ```@```

 * Move ```@``` with the changeset you pushed.

 * Update [[http://patchwork.serpentine.com/project/hg/list/|Patchwork]] once you have pushed
Line 44: Line 72:
 * Patchwork  * [[http://patchwork.serpentine.com/project/hg/list/|Patchwork]] ([[http://hgpatches.appspot.com/?days=30|backlog plot]])
Line 46: Line 74:
 * Patch bomb  * [[http://hgpatches.durin42.com/|The Patches Bot]] ([[http://hg.durin42.com/patchbot/|sources]])
Line 49: Line 77:

 * [[http://www.selenic.com/inbox|Matt Mackall Inbox Metrix]]

Patch Review Process

This page explain the Mercurial Patch Review Process and how (anyone) can help.

1. Generic Fact

2. Simple Review Checklist

  • The patch is compliant to the ContributingChanges bullet list.

    • Quick reminder of important thing:
    • commit message format,
    • Patch does one and one thing,
    • Change is tested
    • Documentation augmented an updated
    • (all the other things in the list)
  • You understand the change
  • The change seems correct
  • The change seems efficient

If any concerns raised, reply to the email asking question.

If everything sounds good, reply to the email too. Just state it looks good to you.

3. Accepters Review Checklist

Some people are blessed to accept patches and push them to a repo where Matt Mackall ultimatly pull from.

Here is another check list for them

  • Run check code on all patches
  • Run the whole test suites
  • Reply to the list saying that you took care of the patch
  • Make sure you created obsolescence marker between the node in the patch and the one you created, e.g. 
    • hg debugobsolete $EMAIL_NODE $NEW_NODE

  • use the drophack extension if you need to drop a changeset you queued

  • Rebase your queue on top of main's @

  • Move @ with the changeset you pushed.

  • Update Patchwork once you have pushed

4. Review Tooling

ReviewProcess (last edited 2022-10-12 15:53:35 by AugieFackler)