|
Size: 338
Comment:
|
Size: 2152
Comment: add drophack extension link
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 5: | Line 5: |
| * all review happen one MailingLists#The_Mercurial-Devel_list | == Generic Fact == * All reviews happen one MailingLists#The_Mercurial-Devel_list |
| Line 9: | Line 12: |
| * Everybody is welcome to do review. | * Review are just email reply to the emailed patch * ``Everyone`` is welcome to do review. == Simple Review Checklist == * The patch is compliant to the ContributingChanges bullet list. Quick reminder of important thing: * commit message format, * Patch does one and one thing, * Change is tested * Documentation augmented an updated * (all the other things in the list) * You understand the change * The change seems correct * The change seems efficient If any concerns raised, reply to the email asking question. If everything sounds good, reply to the email too. Just state it looks good to you. == Accepters Review Checklist == Some people are blessed to accept patches and push them to a repo where Matt Mackall ultimatly pull from. Here is another check list for them * Run check code on all patches * Run the whole test suites * Reply to the list saying that you took care of the patch * Make sure you created obsolescence marker between the node in the patch and the one you created * use the [[https://bitbucket.org/marmoute/mutable-history/src/98b5ac44a25913e546f4588dba5b7a1db39c82d4/hgext/drophack.py?at=default|drophack extension]] if you need to drop a changeset you queued * Rebase your queue on top of main's ```@``` * Move ```@``` with the changeset you pushed. * Update [[http://patchwork.serpentine.com/project/hg/list/|Patchwork]] once you have pushed == Review Tooling == * [[http://patchwork.serpentine.com/project/hg/list/|Patchwork]] ([[http://hgpatches.appspot.com/?days=30|backlog plot]]) * [[http://hgpatches.durin42.com/|The Patches Bot]] ([[http://hg.durin42.com/patchbot/|sources]]) * Collection of script * [[http://www.selenic.com/inbox|Matt Mackall Inbox Metrix]] |
Patch Review Process
This page explain the Mercurial Patch Review Process and how (anyone) can help.
1. Generic Fact
All reviews happen one MailingLists#The_Mercurial-Devel_list
Contributor follow the ContributingChanges and send they patch to the list (hopefully using the PatchbombExtension)
- Review are just email reply to the emailed patch
Everyone is welcome to do review.
2. Simple Review Checklist
The patch is compliant to the ContributingChanges bullet list.
- Quick reminder of important thing:
- commit message format,
- Patch does one and one thing,
- Change is tested
- Documentation augmented an updated
- (all the other things in the list)
- You understand the change
- The change seems correct
- The change seems efficient
If any concerns raised, reply to the email asking question.
If everything sounds good, reply to the email too. Just state it looks good to you.
3. Accepters Review Checklist
Some people are blessed to accept patches and push them to a repo where Matt Mackall ultimatly pull from.
Here is another check list for them
- Run check code on all patches
- Run the whole test suites
- Reply to the list saying that you took care of the patch
- Make sure you created obsolescence marker between the node in the patch and the one you created
use the drophack extension if you need to drop a changeset you queued
Rebase your queue on top of main's @
Move @ with the changeset you pushed.
Update Patchwork once you have pushed
4. Review Tooling
- Collection of script