|
Size: 6162
Comment: the source transformer no longer runs on hgext3rd
|
Size: 4106
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 13: | Line 13: |
| Mercurial 5.0 is the first release that officially has beta support for Python 3. Supported Python 3 versions are 3.5, 3.6, and 3.7. Python 3.8 mostly works, but there are a few known incompatibilities. Mercurial with Python 3 on Windows is not yet widely tested and there are more known issues on Windows compared to Linux, macOS, and other UNIX-like platforms. | '''We will drop support for Python 2.7 for the Mercurial 6.2 release at the latest. We will do it as soon as 6.1 depending on the packaging of TortoiseHg for Python 3 Windows.''' Mercurial 5.2 is the first release that officially has support for Python 3. Supported Python 3 versions are 3.5, 3.6, 3.7, and 3.8. Mercurial with Python 3 on Windows is tested regularly, but there remains some known issues outside of the core. |
| Line 17: | Line 19: |
| Many 3rd party extensions have not yet been ported to work with Python 3. | Most used 3rd party extensions like evolve and topic have been ported to Python 3. There are some which have not yet been ported. |
| Line 21: | Line 23: |
| Mercurial's `setup.py` file refuses to run with Python 3 by default. This means that `pip install Mercurial` or `python setup.py install` will not work with Python 3 by default. Setting the `HGPYTHON3` environment variable will suppress this error and allow execution with Python 3. e.g. `HGPYTHON3=1 pip3.7 install Mercurial` or `HGPYTHON3=1 python3.7 setup.py install`. |
Since Mercurial 5.2, `setup.py` no longer refuses to run with Python 3. `pip install Mercurial` or `python setup.py install` should work out of the box. But be aware that Windows support is still considered a beta level. |
| Line 29: | Line 31: |
| * Windows encoding changes | * Windows encoding changes (fixed in 5.3) |
| Line 31: | Line 33: |
Probably need to call {{{sys._enablelegacywindowsfsencoding()}}} at startup. |
|
| Line 33: | Line 37: |
== Beta bugs == Following are things which don't work right now: * ~1% of tests fail * phabricator extension * Many 3rd party extensions * [[https://docs.python.org/3/whatsnew/3.6.html#pep-529-change-windows-filesystem-encoding-to-utf-8|Windows filesystem encoding]] If you find anything apart from this not working, definitely go ahead and edit this page and we will fix it. |
|
| Line 61: | Line 54: |
| == Source Rewriting Module Importer == As of at least the Mercurial 5.0 release, Mercurial uses a custom module importer on Python 3 which rewrites source code dynamically as part of importing modules. This module importer is only active for the `mercurial` and `hgext` packages. This means that Mercurial's own source code and extensions are not yet native Python 3 source code. So if you look at Mercurial's source code for ideas on how to do something in an extension, behavior in the extension may differ from Mercurial itself due to the presence of this custom module importer. In the 5.0 release, the custom module importer performs the following actions: * Automatically adds `b''` prefixes to strings, making all `''` literals `b''` and effectively changing `str` to `bytes` everywhere. i.e. behavior mostly matches Python 2. * Modules automatically have `from mercurial.pycompat import delattr, getattr, hasattr, setattr, open, unicode` added. * `getattr()`, `setattr()`, `hasattr()`, `safehasattr()`, `encode()`, and `decode()` functions and methods have string literals in arguments rewritten to the appropriate type because Python requires a `str` value instead of `bytes`. (This effectively selectively undoes the global `''` to `b''` source transformation.) * `iteritems()` and `itervalues()` are automatically rewritten to `items()` and `values()`, respectively. The source rewriting module importer is intended to be a stop-gap to make porting Mercurial to Python 3 simpler and will be removed in a future release. This is why extensions do not use it. More history about this importer is available at https://gregoryszorc.com/blog/2017/03/13/from-__past__-import-bytes_literals/ |
Note:
This page is primarily intended for developers of Mercurial.
Python 3
This is a status page for keeping track of what needs to be done to make progress on Mercurial on Python 3.
1. Status
We will drop support for Python 2.7 for the Mercurial 6.2 release at the latest. We will do it as soon as 6.1 depending on the packaging of TortoiseHg for Python 3 Windows.
Mercurial 5.2 is the first release that officially has support for Python 3. Supported Python 3 versions are 3.5, 3.6, 3.7, and 3.8. Mercurial with Python 3 on Windows is tested regularly, but there remains some known issues outside of the core.
It is the project policy for Mercurial and its core extensions to be compatible with Python 3. Over 99% of tests pass with Python 3 and test regressions are treated seriously.
Most used 3rd party extensions like evolve and topic have been ported to Python 3. There are some which have not yet been ported.
2. Using
Since Mercurial 5.2, setup.py no longer refuses to run with Python 3. pip install Mercurial or python setup.py install should work out of the box. But be aware that Windows support is still considered a beta level.
No run-time environment variable or config option is required to use Python 3 with Mercurial: only the installation step / setup.py requires special action to override the Python version check.
3. Things need to be investigated
- Windows encoding changes (fixed in 5.3)
https://docs.python.org/3/whatsnew/3.6.html#pep-529-change-windows-filesystem-encoding-to-utf-8
Probably need to call sys._enablelegacywindowsfsencoding() at startup.
Lazy importer performance overhead. Our custom importer on Python 2 always returns a stub module during import. Python 3's does I/O to verify the module exists then returns a lazy module that is loaded when first accessed. In addition to behavior differences, the I/O may contribute sufficient performance overhead to constitute a problem.
- A mechanism for extensions to advertise that they are Python 3 compatible. Nearly every extension will break in Python 3. We may want a mechanism that requires extensions to self-declare that they are Python 3 compatible - possibly via special syntax in their source code or the presence of a well-named variable. It might have to be at the source level because Python 3 would need to evaluate code in order to obtain the value of a module-level variable.
4. Porting Extensions to Python 3
Nearly every extension will need to be ported to be compatible with Python 3. This is because of fundamental differences between Python 2 and Python 3.
The source code for Mercurial extensions will need to be Python 3 native and will need to be compatible with Mercurial's APIs. In many cases, existing source code will compile on Python 3 but will fail at run-time. Sources of run-time errors include:
Use of str instead of bytes. Mercurial uses bytes (b'' strings) in almost all of its APIs and data structures. This is in contrast to much Python code, which uses str and '' strings. It is common for extensions to b'' prefix most strings in order to remain compatible with Mercurial.
Use of iteritems(), iterkeys(), etc. These methods from core data structures do not exist in Python 3.
- Import of renamed modules. Python 3 refactored the locations of various modules in the Python standard library. Extensions may need to take this into account.
Do an Internet search for Python 3 porting to find well-written and comprehensive guides on generically porting code to Python 3.
Extension authors may find the mercurial.pycompat module useful. This modules contains abstractions and utilities for bridging the differences between Python 2 and 3. It is conceptually similar to the six Python module.
If you need help or guidance on porting extensions, you can message on IRC or the development MailingList. We will be happy to help you.