|
Size: 948
Comment:
|
Size: 2421
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 3: | Line 3: |
| This is a status page for keeping track of what needs to be done to make progress on Mercurial on Python 3. Nobody is actively working on this - AugieFackler works on it sporadically, and would be happy to see patches on this topic flagged with Py3 on the mailing list. | = Python 3 = |
| Line 5: | Line 5: |
| This is a status page for keeping track of what needs to be done to make progress on Mercurial on Python 3. Our current aim is to support Python 3.5. | |
| Line 6: | Line 7: |
| The most significant problem at the moment is some lingering cyclic imports in the codebase: | == What Works == `hg version` works on Python 3 without using any out of core extensions. `hg debuginstall` is our next goal and it's nearly complete. These won't work for you if you have out of core extensions enabled. |
| Line 8: | Line 10: |
| ==== cmdutil -> subrepo -> cmdutil ==== | == Contributing == |
| Line 10: | Line 12: |
| The easiest fix for this would be to move hgsubrepo to a new file, and then fix the registration mechanism to be dependency injected somehow. | We will be happy to review patches and speed up the work related to Python 3. Before you start there are few things related to current porting and how things work currently. |
| Line 12: | Line 14: |
| ==== mercurial.repoview -> mercurial.revset -> mercurial.repoview ==== | * We have a source transformer which does following things on Python 3. 1. It adds b'' in front of string starting with "'" or '"' and not having any u'', r'' or b'' in front. 2. Adds this line `from mercurial.pycompat import delattr, getattr, hasattr, setattr, xrange, open` on every python file. 3. Converts every occurrence of `iteritems` to `items` on Python 3. 4. Converts argument of *attr and encode, decode to unicodes by adding u''. 5. The transformer currently works on `mercurial/, hgext/ and hgext3rd/`. 6. The transformer code lies [[https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/__init__.py#l124|here]] and you can also use transformer on your .py files by adding them in the transformer. |
| Line 14: | Line 22: |
| * Due to everything is unicodes by default in Python 3, and we need to rely on bytes, we have [[https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/pycompat.py|pycompat.py]] which contains hacks related to various functions of `os` module on Python. | |
| Line 15: | Line 24: |
| ==== mercurial.fileset -> mercurial.merge -> mercurial.subrepo -> mercurial.match -> mercurial.fileset ==== If hgsubrepo moved out of subrepo, this would also be resolve.d |
* We also have encoding.environ which helps us using a bytes version of os.environ on both Python 2 and 3. |
| Line 18: | Line 26: |
| * There are currently two tests which are based on Python 3 compatibility and few checks in our linter [[https://www.mercurial-scm.org/repo/hg/file/tip/tests/test-check-code.t|test-check-code.t]] to make sure new patches include things from `pycompat.py`. | |
| Line 19: | Line 28: |
| ==== mercurial.filemerge -> mercurial.match -> mercurial.fileset -> mercurial.merge -> mercurial.filemerge ==== | 1. [[https://www.mercurial-scm.org/repo/hg/file/tip/tests/test-check-py3-compat.t|test-check-py3-compat.t]] : This test was used initially to fix a lot of things, not very much helpful now. 2. [[https://www.mercurial-scm.org/repo/hg/file/tip/tests/test-check-py3-commands.t|test-check-py3-commands.t]]: This test which things actually works on Python 3. You can see in the test that `hg version` runs on vanilla hg. |
Note:
This page is primarily intended for developers of Mercurial.
Python 3
This is a status page for keeping track of what needs to be done to make progress on Mercurial on Python 3. Our current aim is to support Python 3.5.
1. What Works
hg version works on Python 3 without using any out of core extensions. hg debuginstall is our next goal and it's nearly complete. These won't work for you if you have out of core extensions enabled.
2. Contributing
We will be happy to review patches and speed up the work related to Python 3. Before you start there are few things related to current porting and how things work currently.
- We have a source transformer which does following things on Python 3.
It adds b in front of string starting with "'" or '"' and not having any u, r or b in front.
Adds this line from mercurial.pycompat import delattr, getattr, hasattr, setattr, xrange, open on every python file.
Converts every occurrence of iteritems to items on Python 3.
Converts argument of *attr and encode, decode to unicodes by adding u.
The transformer currently works on mercurial/, hgext/ and hgext3rd/.
The transformer code lies here and you can also use transformer on your .py files by adding them in the transformer.
Due to everything is unicodes by default in Python 3, and we need to rely on bytes, we have pycompat.py which contains hacks related to various functions of os module on Python.
- We also have encoding.environ which helps us using a bytes version of os.environ on both Python 2 and 3.
There are currently two tests which are based on Python 3 compatibility and few checks in our linter test-check-code.t to make sure new patches include things from pycompat.py.
test-check-py3-compat.t : This test was used initially to fix a lot of things, not very much helpful now.
test-check-py3-commands.t: This test which things actually works on Python 3. You can see in the test that hg version runs on vanilla hg.