Differences between revisions 2 and 3
⇤ ← Revision 2 as of 2012-02-28 14:20:50 →
Size: 898
Editor: PatrickMézard
Comment: Fill "Work in Progress"
← Revision 3 as of 2012-02-28 14:54:17 → ⇥
Size: 2545
Editor: PatrickMézard
Comment: Fill "To Do" section
Deletions are marked like this. Additions are marked like this.
Line 4: Line 4:

A brief description.
Line 11: Line 9:
With these submitted patch series, graphlog supports the same options than log command, and we can consider merging boths: With these submitted patches, graphlog supports the same options as log command, and we can consider merging boths:
Line 14: Line 12:

[[http://selenic.com/pipermail/mercurial-devel/2012-February/038269.html]]
Line 25: Line 25:
[[http://selenic.com/pipermail/mercurial-devel/2012-February/038322.html]]
Line 30: Line 32:
coming soon === log command ===

 1. Make "pats" unique after their expansion if they are not already. They are used to generate follow()/file() expressions in the fast path
 1. Check escaping/injection issues. We already have a test for --branch and I am not sure there are more issues with regular options, but we certainly want to parse the --rev expressions before adding them to the synthetic revset (like revset.formatspec() does).
 1. Replace commands.log() and cmdutil.walkchangerevs() with graphlog.graphlog(). Run the tests and see what was missed. Make it feature complete.
 1. Profile the revsets. Most of them are single functions. There are 2 or 3 "not something()" and --prune is a bit more complicated. Note sure there is much to do except tweak the expression weights.
 1. Think a bit about killing hgext/graphlog.py, compatibility and perhaps leaving stubs here.
 1. Profit!

=== incoming/outgoing commands ===

 1. Decide what to do about --newest-first
 1. ? Look at hg._incoming()/_outgoing() (recurse in subrepos ?)

=== random improvements ===

 1. Improve the error message on --follow FILE --removed, [[http://mercurial.selenic.com/bts/issue2139|issue2139]]
 1. Document that "hg log 'set:added()'" is not the same than "hg log -r 'file("set:added()")'"
 1. Mention filesets in "hg help patterns" before the last line
 1. Display renames correctly with "hg log --follow file", see the second part of this [[http://selenic.com/pipermail/mercurial-devel/2012-February/038275.html|changelog]] for details

Merging Graphlog in Core

Contents

  1. Work in Progress
    1. http://selenic.com/pipermail/mercurial-devel/2012-February/038269.html
    2. http://selenic.com/pipermail/mercurial-devel/2012-February/038322.html
  2. To Do
    1. log command
    2. incoming/outgoing commands
    3. random improvements

1. Work in Progress

With these submitted patches, graphlog supports the same options as log command, and we can consider merging boths:

1.1. http://selenic.com/pipermail/mercurial-devel/2012-February/038269.html

http://selenic.com/pipermail/mercurial-devel/2012-February/038269.html

  • graphlog: implement --copies
  • graphlog: evaluate FILE/-I/-X filesets on the working dir
  • match: consider filesets as "anypats"
  • test-glog: rewrite more tests using testlog() function
  • graphlog: fix --removed
  • context: add followfirst arg to filectx and workingfilectx
  • graphlog: apply file filters --patch/--stat output

1.2. http://selenic.com/pipermail/mercurial-devel/2012-February/038322.html

http://selenic.com/pipermail/mercurial-devel/2012-February/038322.html

  • revset: add hidden() revset, undocumented
  • graphlog: support --hidden

2. To Do

2.1. log command

  1. Make "pats" unique after their expansion if they are not already. They are used to generate follow()/file() expressions in the fast path
  2. Check escaping/injection issues. We already have a test for --branch and I am not sure there are more issues with regular options, but we certainly want to parse the --rev expressions before adding them to the synthetic revset (like revset.formatspec() does).
  3. Replace commands.log() and cmdutil.walkchangerevs() with graphlog.graphlog(). Run the tests and see what was missed. Make it feature complete.
  4. Profile the revsets. Most of them are single functions. There are 2 or 3 "not something()" and --prune is a bit more complicated. Note sure there is much to do except tweak the expression weights.
  5. Think a bit about killing hgext/graphlog.py, compatibility and perhaps leaving stubs here.
  6. Profit!

2.2. incoming/outgoing commands

  1. Decide what to do about --newest-first
  2. ? Look at hg._incoming()/_outgoing() (recurse in subrepos ?)

2.3. random improvements

  1. Improve the error message on --follow FILE --removed, issue2139

  2. Document that "hg log 'set:added()'" is not the same than "hg log -r 'file("set:added()")'"
  3. Mention filesets in "hg help patterns" before the last line

  4. Display renames correctly with "hg log --follow file", see the second part of this changelog for details

CategoryAudit

MergingGraphlogInCorePlan (last edited 2012-11-06 23:07:02 by abuehl)